Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permanently deleted app/helpers/ui_constants.rb ... end of issue #1661 #2165

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Permanently deleted app/helpers/ui_constants.rb ... end of issue #1661 #2165

merged 1 commit into from
Sep 12, 2017

Conversation

europ
Copy link
Member

@europ europ commented Sep 12, 2017 •
edited
Loading

Closes: #1661

Issue: #1661

Needs to be merged together with ManageIQ/manageiq#15965

UiConstants were removed permanently.

@miq-bot miq-bot added the wip label Sep 12, 2017
@europ europ force-pushed the remove-ui-constants-59-FINAL branch from bf4de9f to 6b601c9 Compare September 12, 2017 08:18
@europ
Copy link
Member Author

europ commented Sep 12, 2017

@mzazrivec
Should I also remove this?
https://github.com/ManageIQ/manageiq-ui-classic/blob/master/lib/report_formatter.rb#L2

@mzazrivec
Copy link
Contributor

@europ Yes

@europ europ force-pushed the remove-ui-constants-59-FINAL branch from 6b601c9 to f3aaf08 Compare September 12, 2017 08:46
@miq-bot
Copy link
Member

miq-bot commented Sep 12, 2017

Checked commit europ@f3aaf08 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. 👍

@europ europ mentioned this pull request Sep 12, 2017
Merged
@europ
Copy link
Member Author

europ commented Sep 12, 2017

@miq-bot add_label pending core

@europ europ changed the title [WIP] Permanently deleted app/helpers/ui_constants.rb ... end of issue #1661 Permanently deleted app/helpers/ui_constants.rb ... end of issue #1661 Sep 12, 2017
@miq-bot miq-bot added pending core and removed wip labels Sep 12, 2017
@chrisarcand
Copy link
Member

@miq-bot remove_label pending core

@mzazrivec mzazrivec self-assigned this Sep 12, 2017
@mzazrivec mzazrivec added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 12, 2017
@mzazrivec mzazrivec merged commit a0deadd into ManageIQ:master Sep 12, 2017
@europ europ deleted the remove-ui-constants-59-FINAL branch September 12, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@europ @mzazrivec @miq-bot @chrisarcand